时间戳

首页 > 解决方案 > Spring Boot @ControllerAdvice + @Transactional 无法按预期工作

java - Spring Boot @ControllerAdvice + @Transactional 无法按预期工作

问题描述

我在一个投注网站上工作，所以交易非常重要。我创建了一个 ExceptionHandler@ControllerAdvice用于捕获来自业务层的所有异常。

@ControllerAdvice
public class HttpExceptionHandler {

  private String getStackTrace(final Throwable throwable) {
    final StringWriter stringWriter = new StringWriter()
    final PrintWriter printWriter = new PrintWriter(stringWriter, true)
    throwable.printStackTrace(printWriter)
    stringWriter.getBuffer().toString()
  }

  private List<String> filterStackTrace(final String stackTrace) {
    def stack = stackTrace.split('\n\t')
    stack.findAll({ it.contains('com.dsindigo.trading') })
  }

  private ResponseEntity<HttpErrorResponse> buildResponse(final Exception ex, final String message) {
    HttpErrorResponse error = new HttpErrorResponse(
      stack: filterStackTrace(getStackTrace(ex)),
      message: message
    )

    new ResponseEntity<HttpErrorResponse>(error, HttpStatus.BAD_REQUEST)
  }

  @ExceptionHandler(UsernameAlreadyExistsException)
  ResponseEntity<HttpErrorResponse> catchUsernameAlreadyExists(final UsernameAlreadyExistsException ex) {
    buildResponse(ex, HttpErrorMessages.USERNAME_ALREADY_EXISTS)
  }

  @ExceptionHandler(EmailAlreadyExistsException)
  ResponseEntity<HttpErrorResponse> catchEmailAlreadyExists(final EmailAlreadyExistsException ex) {
    buildResponse(ex, HttpErrorMessages.EMAIL_ALREADY_EXISTS)
  }

  //More exceptions...

  @ExceptionHandler(Exception)
  ResponseEntity<HttpErrorResponse> catchAny(final Exception ex) {
    buildResponse(ex, HttpErrorMessages.UNKNOWN)
  }
}

所以基本上它会捕获一个异常（例如。UsernameAlreadyExistsException）并创建一个包含自定义消息和堆栈跟踪（用于调试目的）的 JSON 响应。

这是一个抛出自定义异常的服务示例：

@Service
class UserServiceImpl implements UserService {

  // @Autowired stuff ...

  @Override
  @Transactional
  UserDTO save(UserDTO user) {
    UserDTO current = findOneByUsername(user.username)

    if (current != null)
      throw new UsernameAlreadyExistsException()

    current = findOneByEmail(user.email)

    if (current != null)
      throw new EmailAlreadyExistsException()

    ConfigurationDTO configuration = configurationService.findOne();

    user.active = false
    user.password = bCryptPasswordEncoder.encode(user.password)
    user.balance = configuration.initialBalance

    User entity = mapper.map(user, User)
    entity = userRepository.save(entity)
    user = mapper.map(entity, UserDTO)

    transactionService.createForUser(user.id, INITIAL_CHIPS_ID, configuration.initialBalance)

    TokenDTO token = tokenService.createForUser(user.id)
    emailService.sendRegisterMessage(user.email, token.token)

    user
  }
}

问题是，当我在没有@Transactional异常处理程序的情况下抛出自定义异常时，会执行正确的方法，但添加@Transactional总是会执行通用Exception方法。

我错过了什么吗？

标签： javaspring-boottransactional

解决方案

这些声明：

@ExceptionHandler(UsernameAlreadyExistsException)

应该是这样的：

@ExceptionHandler(UsernameAlreadyExistsException.class)

此外，请确保您的异常正在扩展 RuntimeException。如果在代码中的其他任何地方（包括 Spring 的拦截器！）捕获并处理了异常，ControllerAdvice 将不会处理它。

推荐阅读