c# - 是否可以使用模拟对象作为另一种模拟方法的输入？

Question

我创建了一个先前的测试方法，在单个数据访问上设置了两个模拟对象，它工作正常。做了另一个有相同情况的，但结果失败了。

下面是测试方法：

[Test]
public void UpdateUserPassword_WhenInputsAreCorrect_ReturnsQuerySuccessMessage()
    {
        UpdatePasswordModel input = new UpdatePasswordModel()
        {
            UserName = "john.doe",
            NewPassword = "password1", //password1
            PreviousPassword = "password" //password
        };

        Mock<IUserDataAccess> user = new Mock<IUserDataAccess>();
        Mock<IDailyTimeInDataAccess> timeIn = new Mock<IDailyTimeInDataAccess>();
        Mock<IDailyTimeOutDataAccess> timeOut = new Mock<IDailyTimeOutDataAccess>();

        user.Setup(x => x.UpdatePassword(10000, input.NewPassword)).Returns("User record updated.");
        user.Setup(x => x.GetUser(input.UserName)).Returns(new User()
        {
            UserKey = 10000,
            UserName = "john.doe",
            UserPassword = "LTg9BIob8urwz643K5+pBA=="
        });

        ILoginBusinessRules app = new LoginBusinessRules(user.Object, timeIn.Object, timeOut.Object);

        var output = app.UpdateUserPassword(input);

        Assert.AreEqual("User record updated.", output);
    }

这是业务规则：

public string UpdateUserPassword(UpdatePasswordModel model)
    {
        if (model == null)
        {
            return "No data to process.";
        }
        if (string.IsNullOrEmpty(model.UserName))
        {
            return "Username is empty.";
        }
        if (string.IsNullOrEmpty(model.NewPassword))
        {
            return "New Password is empty.";
        }
        if (string.IsNullOrEmpty(model.PreviousPassword))
        {
            return "Previous Password is empty.";
        }

        var user = _userDataAccess.GetUser(model.UserName);
        if (user == null)
        {
            return "User not found.";
        }

        if (user.UserPassword != EncryptPassword(model.PreviousPassword))
        {
            return "Previous password does not match.";
        }
        else
        {
            user.UserPassword = EncryptPassword(model.NewPassword);
            user.UpdateDttm = DateTime.Now;
            user.UpdateUserId = model.UserName;

            var result = _userDataAccess.UpdatePassword(user.UserKey, user.UserPassword);

            return result;
        }
    }

测试返回失败。进一步调试告诉我，这里的这一行返回 null：

var result = _userDataAccess.UpdatePassword(user.UserKey, user.UserPassword);

非常感谢任何帮助！

标签： c#tddmoq

Answer 1

测试中的Setup用途input.NewPassword是

UpdatePasswordModel input = new UpdatePasswordModel() {
    //...
    NewPassword = "password1",
    //...
};

//...

user.Setup(x => x.UpdatePassword(10000, input.NewPassword)).Returns("User record updated.");

//...

但在被测方法中，该方法是用另一个值调用的

//...

user.UserPassword = EncryptPassword(model.NewPassword);

//...

var result = _userDataAccess.UpdatePassword(user.UserKey, user.UserPassword);

这与设置中的预期不匹配。

当模拟成员未按预期调用时，它将返回返回类型的默认值，在这种情况下为null

您需要确保在设置期望中使用正确的值

例如

user
    .Setup(x => x.UpdatePassword(10000, EncryptPassword(input.NewPassword)))
    .Returns("User record updated.");

或使用类似的参数匹配器放松设置的期望It.IsAny<T>()

   user
    .Setup(x => x.UpdatePassword(10000, It.IsAny<string>()))
    .Returns("User record updated.");