ruby - 运行 Rspec 和 Sinatra 时,我不断收到 ArgumentError: wrong number of arguments (given 2, expected 0)
问题描述
我有一个名为 authenticate 的类方法,它适用于 User 类。
def self.authenticate(email:, password:)
result = DatabaseConnection.query("SELECT * FROM users WHERE email = '#{email}'")
User.new(result[0]['id'], result[0]['email'])
end
我有一个 Rspec 测试;
feature 'authentication' do
it 'a user can sign in' do
User.create(email: 'test@example.com', password: 'password123')
visit 'sessions/new'
fill_in(:email, with: 'test@example.com')
fill_in(:password, with: 'password123')
click_button 'Sign In'
expect(page).to have_content 'Welcome, test@example.com'
end
end
运行 Rspec 时,出现以下错误;
1) authentication a user can sign in
Failure/Error:
def initialize(id:, email:)
@id = id
@email = email
end
ArgumentError:
wrong number of arguments (given 2, expected 0)
# ./lib/user.rb:15:in `initialize'
# ./lib/user.rb:23:in `new'
# ./lib/user.rb:23:in `authenticate'
# ./app.rb:84:in `block in <class:BookmarkManager>'
下面是我的 Sinatra 应用程序;
require 'sinatra/base'
require './lib/bookmark'
require './lib/user'
require './database_connection_setup.rb'
require 'uri'
require 'sinatra/flash'
require_relative './lib/tag'
require_relative './lib/bookmark_tag'
class BookmarkManager < Sinatra::Base
enable :sessions, :method_override
register Sinatra::Flash
get '/' do
"Bookmark Manager"
end
get '/bookmarks' do
@user = User.find(session[:user_id])
@bookmarks = Bookmark.all
erb :'bookmarks/index'
end
post '/bookmarks' do
flash[:notice] = "You must submit a valid URL" unless Bookmark.create(url: params[:url], title: params[:title])
redirect '/bookmarks'
end
get '/bookmarks/new' do
erb :'bookmarks/new'
end
delete '/bookmarks/:id' do
Bookmark.delete(id: params[:id])
redirect '/bookmarks'
end
patch '/bookmarks/:id' do
Bookmark.update(id: params[:id], title: params[:title], url: params[:url])
redirect('/bookmarks')
end
get '/bookmarks/:id/edit' do
@bookmark = Bookmark.find(id: params[:id])
erb :'bookmarks/edit'
end
get '/bookmarks/:id/comments/new' do
@bookmark_id = params[:id]
erb :'comments/new'
end
post '/bookmarks/:id/comments' do
Comment.create(text: params[:comment], bookmark_id: params[:id])
redirect '/bookmarks'
end
get '/bookmarks/:id/tags/new' do
@bookmark_id = params[:id]
erb :'/tags/new'
end
post '/bookmarks:id/tags' do
tag = Tag.create(content: params[:tag])
BookmarkTag.create(bookmark_id: params[:id], tag_id: tag.id)
redirect '/bookmarks'
end
get '/users/new' do
erb :'users/new'
end
post '/users' do
user = User.create(email: params[:email], password: params[:password])
session[:user_id] = user.id
redirect '/bookmarks'
end
get '/sessions/new' do
erb :'sessions/new'
end
post '/sessions' do
user = User.authenticate(email: params[:email], password: params[:password])
if user
session[:user_id] = user.id
redirect('/bookmarks')
else
flash[:notice] = 'Please check your email or password.'
redirect('/sessions/new')
end
end
run! if app_file == $0
end
下面是完整的用户类
require_relative './database_connection'
require 'bcrypt'
class User
def self.create(email:, password:)
encypted_password = BCrypt::Password.create(password
)
result = DatabaseConnection.query("INSERT INTO users (email, password) VALUES('#{email}', '#{encypted_password}') RETURNING id, email;")
User.new(id: result[0]['id'], email: result[0]['email'])
end
attr_reader :id, :email
def initialize(id:, email:)
@id = id
@email = email
end
def self.authenticate(email:, password:)
result = DatabaseConnection.query("SELECT * FROM users WHERE email = '#{email}'")
User.new(result[0]['id'], result[0]['email'])
end
def self.find(id)
return nil unless id
result = DatabaseConnection.query("SELECT * FROM users WHERE id = #{id}")
User.new(
id: result[0]['id'],
email: result[0]['email'])
end
end
我不明白的是,为什么 Rspec 说它期待 0 个参数,而该initialize
方法显然需要两个参数(id 和 email)?我需要从中获取 id 和 email 方法authenticate
并将其传递到initialize
. 我认为这就是我正在做的事情,但 Rspec 和 sinatra 都不是这么说的。
提前致谢。
解决方案
在这里,您将 id 作为顺序参数传递(在authenticate
方法中)。
User.new(result[0]['id'], result[0]['email'])
但是,您User.new
期望关键字 args:
def initialize(id:, email:)
只需以这种方式传递它们:
User.new(id: result[0]['id'], email: result[0]['email'])
另外,我注意到的一点是,如果您DatabaseConnection.query
没有返回任何结果,您authenticate
将引发一个错误result[0]['id']
(它会说"Undefined method [] for Nil:NilClass"
. 也许您应该解决这个问题并为其添加一个测试用例,例如:
def self.authenticate(email:, password:)
result = DatabaseConnection.query(
"SELECT * FROM users WHERE email = '#{email}'"
)
record = result[0]
if record
User.new(id: result[0]['id'], email: result[0]['email'])
end
end
这样,nil
如果没有匹配的用户,该方法将返回,并且您的if user
内部post '/sessions'
将正常工作。
推荐阅读
- reactjs - 如何在 Recharts CartesianGrid 中自定义水平线位置?
- django - Django 在一个休息请求中创建/更新多个模型
- nginx - hapi 服务器:当我使用 POST 方法请求时,hapi 服务器以 null 响应,但在 localhost 中工作正常
- python - 使用 re.findall 对文件夹中的文件进行排序制作高效代码
- vue.js - 如何将 dart-vm 集成到 vue-cli 应用程序中?
- android - 注销后未显示 GoogleSignInClient 帐户选择器
- ios - 在 iOS 上禁用 RemoteIO 和 VPIO 的输入/输出 AGC
- android - Jetpack Compose:如何将 LazyVerticalGrid 放入可滚动列中?
- python - 如何使用 Python 更改抓取图像的名称?
- java - JavaFX 搜索过滤器返回额外的行