首页 > 解决方案 > Java、套接字、线程

问题描述

您好亲爱的 StackOverflow 用户。我又来这里回答一个关于Java Socket and Thread的问题。我当前的代码:

new Thread(()->{
             System.out.println("Thread.......");
            try {
                while(true){
                     ServerSocket serverSocket = new ServerSocket(serverPort);
                     Socket socket = serverSocket.accept();
                        final InputStreamReader streamReader = new InputStreamReader(socket.getInputStream());
                        BufferedReader br = new BufferedReader(streamReader);
                        String line = null;
                        while ((line = br.readLine()) != null){
                            JsonObject result = new Gson().fromJson(line, JsonObject.class);
                            String token = result.get("serverToken").getAsString();
                            String player = result.get("player").getAsString();
                            String value = result.get("quantity").getAsString();
                            System.out.println(token+"/"+serverToken);
                            if(token.equals(serverToken)){
                                String command = activeCommand;
                                       command = activeCommand.replace("%value%", value);
                                       command = activeCommand.replace("%player%", player);
                                execCommand(command);
                                System.out.println("Acertou a token!");
                            }else{
                                System.out.println("Token incorreta!");
                            }
                        }
                     serverSocket.close();
                     socket.close();
                     Boolean isClosed = socket.isClosed();
                     System.out.print(isClosed);
                  } 
            } catch (IOException e) {
                System.out.println(e);
            }
        }).start();

它运作良好,在一定程度上。几次请求后,它只是给出了错误:java.net.BindException: Address already in use (Bind failed)

我一直在寻找一段时间,但我还没有找到解决方案。提前致谢。

标签: javamultithreadingsocketsbukkit

解决方案


我没有明确的答案,但我确实有一些可能的问题和一些改进

  1. 您没有关闭某些 Closeable 资源。
  2. 可能会抛出异常,但不会在此线程中捕获。

改进

  1. 4 个可关闭的对象都放入多个 try-with-resources。
  2. 您现在正在使用打印所有未捕获异常的 ThreadFactory。
  3. 您现在正在打印 IOException(如果发生)。
  4. 您现在正在使用使用 ThreadFactory 的 ExecutorService。
        ThreadFactory threadFactory = new ThreadFactoryBuilder()
                .setUncaughtExceptionHandler((thread, throwable) -> throwable.printStackTrace())
                .setNameFormat("my-server-thread")
                .build();

        ExecutorService service = Executors.newSingleThreadScheduledExecutor(threadFactory);

        service.submit(() -> {
            while(true) {
                try (ServerSocket serverSocket = new ServerSocket(port)) {
                    try (Socket socket = serverSocket.accept()) {
                        try (InputStreamReader streamReader = new InputStreamReader(socket.getInputStream());
                             BufferedReader br = new BufferedReader(streamReader)) {
                            String line;

                            while ((line = br.readLine()) != null) {
                                // your other code in here
                            }
                        }
                    }
                } catch (IOException ioe) {
                    ioe.printStackTrace();
                }
            }
        });

推荐阅读