首页 > 解决方案 > 从 Rails 6 控制台运行“User.create”时如何创建有效邮件

问题描述

我正在关注 Michael Hartl 的教程,当我尝试在我的users表中创建用户时遇到问题。

当我User.create从 Rails 控制台运行时,我总是得到:

@messages={:email=>["is invalid"]}"

user.errors. 我的测试也失败了:

FAIL["test_email_validation_should_accept_valid_addresses",                                             #<Minitest::Reporters::Suite:0x00007f66146c67f0 @name="UserTest">, 0.05937384600110818]
 test_email_validation_should_accept_valid_addresses#UserTest (0.06s)
        "lala@example.com" should be valid

我想这是问题所在,但我不知道为什么。

这也失败了:

test "should be valid" do
  assert @user.valid?
end

如果我这样写,则测试通过:

test "should be valid" do
  assert_not @user.valid?
end

这也失败了:

test "email validation should accept valid addresses" do
  valid_addresses = %w[lala@example.com USER@foo.COM A_US-ER@foo.bar.org first.last@foo.jp alice+bob@baz.cn]
  valid_addresses.each do |valid_address|
    @user.email = valid_address
    assert @user.valid?, "#{valid_address.inspect} should be valid"
  end
end

如果我这样编写测试,它会通过:

test "email validation should accept valid addresses" do
  valid_addresses = %w[lala@example.com USER@foo.COM A_US-ER@foo.bar.org
                         first.last@foo.jp alice+bob@baz.cn]
  valid_addresses.each do |valid_address|
    @user.email = valid_address
    assert_not @user.valid?, "#{valid_address.inspect} should be valid"
  end
end 

这些是警卫错误:

FAIL["test_email_validation_should_accept_valid_addresses", #<Minitest::Reporters::Suite:0x00007f6614891a58 @name="UserTest">, 0.05828664900036529]
 test_email_validation_should_accept_valid_addresses#UserTest (0.06s)
        "lala@example.com" should be valid
        test/models/user_test.rb:39:in `block (2 levels) in <class:UserTest>'
        test/models/user_test.rb:37:in `each'
        test/models/user_test.rb:37:in `block in <class:UserTest>'

 FAIL["test_should_be_valid", #<Minitest::Reporters::Suite:0x00007f6614859ab8 @name="UserTest">, 0.06591933299932862]
 test_should_be_valid#UserTest (0.07s)
        Expected false to be truthy.
        test/models/user_test.rb:11:in `block in <class:UserTest>'

这是我的 user_test.rb:

require 'test_helper'

class UserTest < ActiveSupport::TestCase

  def setup
    @user = User.create(name: "Example User", email: "user@example.com",
                     password: "foobar", password_confirmation: "foobar")
  end

  test "should be valid" do
    assert @user.valid?
  end

  test "name should be present" do
    @user.name = "     "
    assert_not @user.valid?
  end

  test "email should be present" do
    @user.email = "     "
    assert_not @user.valid?
  end

  test "name should not be too long" do
    @user.name = "a" * 51
    assert_not @user.valid?
  end

  test "email should not be too long" do
    @user.email = "a" * 244 + "@example.com"
    assert_not @user.valid?
  end

  test "email validation should accept valid addresses" do
    valid_addresses = %w[lala@example.com USER@foo.COM A_US-ER@foo.bar.org
                         first.last@foo.jp alice+bob@baz.cn]
    valid_addresses.each do |valid_address|
      @user.email = valid_address
      assert @user.valid?, "#{valid_address.inspect} should be valid"
    end
  end


  test "email validation should reject invalid addresses" do
    invalid_addresses = %w[user@example,com user_at_foo.org
                          user.name@example. foo@bar_baz.com
                          foo@bar+baz.com]
    invalid_addresses.each do |invalid_address|
      @user.email = invalid_address
      assert_not @user.valid?, "#{invalid_address.inspect} should be invalid"
    end
  end

  test "email address should be unique" do
    duplicate_user = @user.dup
    @user.save
    assert_not duplicate_user.valid?
  end

  test "password should present (nonblank)" do
    @user.password = @user.password_confirmation = " " * 5
    assert_not @user.valid?
  end

  test "password should have a minimum length" do
    @user.password = @user.password_confirmation = "a" * 5
    assert_not @user.valid?
  end


end

这是我的user.rb

class User < ApplicationRecord
  before_save { self.email = email.downcase}
  validates :name, presence: true, length: {maximum: 50}
  VALID_EMAIL_REGEX = /[\w+\-.]+@[a-z\-.]+\.[a-z]+/i
  validates :email, presence: true, length: { maximum: 255},
            format: { with: /VALID_EMAIL_REGEX/},
            uniqueness: false
  has_secure_password
  validates :password, presence:true, length: { minimum: 6}
end

标签: ruby-on-railsruby

解决方案


:format通过测试它们是否匹配给定的正则表达式来验证属性的值,该正则表达式是使用:with选项指定的。

ARegexp包含一个正则表达式,用于将模式与字符串匹配。正则表达式是使用/.../

你的正则表达式是/VALID_EMAIL_REGEX/. 这意味着有效的电子邮件必须包含这些符号。

因此,您的代码表示"VALID_EMAIL_REGEX@gmail.com"有效,但"example@gmail.com"无效。

实际上,您对 regexp 保持不变VALID_EMAIL_REGEX

因此,您需要将代码更改为:

format: { with: VALID_EMAIL_REGEX }

(与正则表达式一致,而不是正则表达式)

顺便说一句,您不需要为电子邮件编写困难的正则表达式。您可以使用标准库中的正则表达式:

format: { with: URI::MailTo::EMAIL_REGEXP }

推荐阅读