I've tried using the below code to load some data from my database and display them in an activity:

PhoneNumberViewModel phoneNumberViewModel =
,java,android,android-asynctask,android-room"/>
	














    

		

        

            
            时间戳
        

		

		

        
		

    
















	
首页  > 解决方案 > 返回列表的房间查询 freezes application

I've tried using the below code to load some data from my database and display them in an activity:



PhoneNumberViewModel phoneNumberViewModel =













java - 返回列表的房间查询 freezes application

I've tried using the below code to load some data from my database and display them in an activity:



PhoneNumberViewModel phoneNumberViewModel =






问题描述



I've tried using the below code to load some data from my database and display them in an activity:



PhoneNumberViewModel phoneNumberViewModel =
        new ViewModelProvider(WorksideContactCard.this).get(PhoneNumberViewModel.class);

phoneNumberViewModel
    .getPhoneNumbersById(contactID)
    .observe(this,
             numbers -> {
                 phoneNumberList = numbers;
             });




To be precise, I needn't observe the data changing, as the data will be refreshed if the activity is resumed. But the above code freezes my application, although I am accessing the DB using an AsyncTask in my other class.



Why could this be so?



EDIT:



PhoneNumberViewModel.class:



public class PhoneNumberViewModel extends AndroidViewModel {
    private PhoneNumberRepository phoneNumberRepository;
    private LiveData<List<PhoneNumber>> allPhoneNumbers;

    public PhoneNumberViewModel(@NonNull Application application) {
        super(application);
        phoneNumberRepository = new PhoneNumberRepository(application);
        allPhoneNumbers = phoneNumberRepository.getAllPhoneNumbersLive();
    }

    public void insert(PhoneNumber phoneNumber) {
        System.out.println("[PhoneNumberRepository] Adding new phoneNumber");
        phoneNumberRepository.insert(phoneNumber);
    }

    public void update(PhoneNumber phoneNumber) {
        phoneNumberRepository.update(phoneNumber);
    }

    public void delete(PhoneNumber phoneNumber) {
        phoneNumberRepository.delete(phoneNumber);
    }

    public LiveData<List<PhoneNumber>> getAllPhoneNumbers() {
        return allPhoneNumbers;
    }

    public LiveData<List<PhoneNumber>> getPhoneNumbersById(long contactId)
            throws ExecutionException, InterruptedException {
        return phoneNumberRepository.getPhoneNumbersByContactId(contactId);
    }




PhoneNumberRepository.class



public class PhoneNumberRepository {
    private PhoneNumberDao phoneNumberDao;
    private LiveData<List<PhoneNumber>> allPhoneNumbers;
    private LiveData<List<PhoneNumber>> phoneNumbersByIdList;

    public PhoneNumberRepository(Application application) {

        WorksideDatabase database = WorksideDatabase.getInstance(application);
        phoneNumberDao = database.phoneNumberDao();
        allPhoneNumbers = phoneNumberDao.getAllPhoneNumbers();
    }

    ...

    public LiveData<List<PhoneNumber>> getAllPhoneNumbersLive() {
        return allPhoneNumbers;
    }

    public void deleteAllPhoneNumbers() {
        new DeleteAllPhoneNumbersAsyncTask(phoneNumberDao).execute();
    }

    public LiveData<List<PhoneNumber>> getPhoneNumbersByContactId(long id)
            throws ExecutionException, InterruptedException {
        return new SelectPhoneNumberByIdAsyncTask(phoneNumberDao, id).get();
    }

    private static class SelectPhoneNumberByIdAsyncTask
            extends AsyncTask<Long, Void, LiveData<List<PhoneNumber>>> {

        private PhoneNumberDao phoneNumberDao;
        private Long ID;

        private SelectPhoneNumberByIdAsyncTask(PhoneNumberDao phoneNumberDao, Long contactId) {
            this.phoneNumberDao = phoneNumberDao;
            ID = contactId;
        }

        @Override
        protected LiveData<List<PhoneNumber>> doInBackground(Long... contactId) {

            ID = contactId[0];

            return phoneNumberDao.getPhoneNumbersById(ID);
        }
    }

    ...
}




PhoneNumberDao.class:



@Dao
public interface PhoneNumberDao {

    @Insert
    void insert(PhoneNumber phoneNumber);

    @Update
    void update(PhoneNumber phoneNumber);

    @Delete
    void delete(PhoneNumber phoneNumber);

    // Probably uneeded method
    @Query("DELETE FROM phone_numbers_table")
    void deleteAllPhoneNumbers();

    // Delete entry/entries by ID
    @Query("DELETE FROM phone_numbers_table WHERE id = :phoneNumberId")
    void deleteByPhoneNumberId(long phoneNumberId);

    // Retrieve entry/entries by contact ID
    //    @Query("SELECT * FROM phone_numbers_table WHERE contact_id = :contactId")
    //    List<PhoneNumber> getPhoneNumbersById(long contactId);

    // Retrieve all saved phone numbers in LiveData format
    @Query("SELECT * FROM phone_numbers_table")
    LiveData<List<PhoneNumber>> getAllPhoneNumbers();

    @Query("SELECT * FROM phone_numbers_table WHERE contact_id = :contactId")
    LiveData<List<PhoneNumber>> getPhoneNumbersById(long contactId);

    @Query("SELECT * FROM phone_numbers_table")
    List<PhoneNumber> getAll();
}










return new SelectPhoneNumberByIdAsyncTask(phoneNumberDao, id).get(); 




this here is your problem ,.get() call blocks the main thread
I would suggest switching to Kotlin and using Coroutines or here you can handle this using callbacks and not using AsyncTask.get() which blocks the main thread.Also BTW Async Task is going to be deprecated last I heard ,So keep that in mind too.
This is one solution the problem



public class Repository implements 
SelectPhoneNumberByIdAsyncTask.OnPhoneNumberFound {


@Override
public void onPhoneNumberFound(LiveData<List<Object>> list) {
   //you can get the data you want here
}



} 


 class SelectPhoneNumberByIdAsyncTask extends AsyncTask<Long, Void, 
  LiveData<List<PhoneNumber//Correct this>>> {

interface OnPhoneNumberFound{
    void onPhoneNumberFound(LiveData<List<PhoneNumberDao>> list);
}
OnPhoneNumberFound mListener;


private PhoneNumberDao phoneNumberDao;
private Long ID;

private SelectPhoneNumberByIdAsyncTask(Object phoneNumberDao, Long contactId) {
    this.phoneNumberDao = phoneNumberDao;
    ID = contactId;
}

@Override
protected LiveData<List<Object>> doInBackground(Long... contactId) {
    ID = contactId[0];
    mListener.onPhoneNumberFound(phoneNumberDao.getPhoneNumbersById(ID));
    return null;
}




}



use .execute() call now instead of .get()


标签： javaandroidandroid-asynctaskandroid-room


解决方案









return new SelectPhoneNumberByIdAsyncTask(phoneNumberDao, id).get(); 




这是你的问题，.get() 调用阻塞了主线程我建议切换到 Kotlin 并使用 Coroutines，或者在这里你可以使用回调而不是使用阻塞主线程的 AsyncTask.get() 来处理这个问题。顺便说一句，异步任务我上次听说会被弃用，所以也要记住这一点。这是解决问题的一种方法



public class Repository implements 
SelectPhoneNumberByIdAsyncTask.OnPhoneNumberFound {


@Override
public void onPhoneNumberFound(LiveData<List<Object>> list) {
   //you can get the data you want here
}



} 


 class SelectPhoneNumberByIdAsyncTask extends AsyncTask<Long, Void, 
  LiveData<List<PhoneNumber//Correct this>>> {

interface OnPhoneNumberFound{
    void onPhoneNumberFound(LiveData<List<PhoneNumberDao>> list);
}
OnPhoneNumberFound mListener;


private PhoneNumberDao phoneNumberDao;
private Long ID;

private SelectPhoneNumberByIdAsyncTask(Object phoneNumberDao, Long contactId) {
    this.phoneNumberDao = phoneNumberDao;
    ID = contactId;
}

@Override
protected LiveData<List<Object>> doInBackground(Long... contactId) {
    ID = contactId[0];
    mListener.onPhoneNumberFound(phoneNumberDao.getPhoneNumbersById(ID));
    return null;
}




}



现在使用 .execute() 调用而不是 .get()










推荐阅读