python - 在 python 3 中改进我的刽子手游戏代码的建议
问题描述
我正在为使用 python 3 构建的刽子手游戏编写此代码。
只要您的words.txt
文件与脚本位于同一文件夹中,该代码就可以完美运行,但我需要改进它的建议。
有很多代码重复和我可以编写得更好的点,而且我在代码重构中苦苦挣扎。有什么意见和建议吗?
class Hangman(object):
def __init__(self):
self.secret_word = self.get_secret_word()
self.correct_letters = []
self.missed_letters = []
self.error = 0
def get_secret_word(self):
from random import choice
with open("words.txt") as f:
wordsList = f.read().splitlines()
secretWord = choice(wordsList).lower()
return secretWord
def read_player_input(self):
self.inputChar = input("\nType a letter: ")
def guess_letter(self):
if (
self.inputChar in self.secret_word
and self.inputChar not in self.correct_letters
):
self.correct_letters.append(self.inputChar)
return True
elif (
self.inputChar not in self.secret_word
and self.inputChar not in self.missed_letters
):
self.missed_letters.append(self.inputChar)
self.error += 1
print(f"\nError {self.error}.")
return False
else:
print("\nYou've already tried this letter.")
return False
def print_encoded_word(self):
self.encoded_word = ""
for letter in self.secret_word:
if letter not in self.correct_letters:
self.encoded_word += "_"
else:
self.encoded_word += letter
print()
print(self.encoded_word)
print("\nCorrect letters: ", end="")
for letter in self.correct_letters:
print(letter + " ", end="")
print("\nWrong letters: ", end="")
for letter in self.missed_letters:
print(letter + " ", end="")
def game_continue(self):
return set(self.correct_letters) != set(self.secret_word) and (self.error <= 3)
def won_game(self):
if set(self.correct_letters) == set(self.secret_word):
print(self.secret_word)
print("You win!")
else:
print(f"You lose. Secret word is {self.secret_word}")
def main():
hangman = Hangman()
hangman.print_encoded_word()
hangman.read_player_input()
hangman.guess_letter()
while hangman.game_continue():
hangman.print_encoded_word()
hangman.read_player_input()
hangman.guess_letter()
hangman.won_game()
if __name__ == "__main__":
main()
解决方案
我建议使用 main() ,就好像您会扩展代码并希望在程序运行时调用更多函数一样。另外,我会在您完成文件后关闭它(您可以在此处了解原因)。
我在下面要更改的函数上添加了注释“#”:
class Hangman(object):
def get_secret_word(self):
from random import choice
with open("words.txt") as f:
wordsList = f.read().splitlines()
secretWord = choice(wordsList).lower()
f.close() #close the file
return secretWord
def print_encoded_word(self):
self.encoded_word = ""
for letter in self.secret_word:
if letter not in self.correct_letters:
self.encoded_word += "_"
else:
self.encoded_word += letter
print() #what is this print doing here?
print(self.encoded_word)
print("\nCorrect letters: ", end="")
for letter in self.correct_letters:
print(letter + " ", end="")
print("\nWrong letters: ", end="")
for letter in self.missed_letters:
print(letter + " ", end="")
def play(): #add this function
hangman.print_encoded_word()
hangman.read_player_input()
hangman.guess_letter()
while hangman.game_continue():
hangman.print_encoded_word()
hangman.read_player_input()
hangman.guess_letter()
hangman.won_game()
def main(): #remove stuff that is now in play()
hangman = Hangman()
hangman.play() #add this
我需要知道每个函数究竟做了什么才能给出更多建议,但似乎其余的都很好。
推荐阅读
- javascript - 如何使用 JavaScript 将 JSON 文件从 HTML 页面发送到 ESP
- swift - 有什么方法可以在 ScrollView 中使用 SwiftUIRefresh(siteline)
- kubernetes - 仅将 Kubernetes ingress-nginx 绑定到特定地址/接口
- java - 如何获取我在 Imageview for Android Studio 上选择的图像上的图像文件名?
- node.js - Dockerizing React-Express- MongoDB Atlas 应用程序与 Docker-Compose 和代理
- c++ - MSVS/C++:不会被优化掉的最快的总是假的条件?
- html - ReactJs 中使用 ReactMapGL 的无响应页面布局
- powerbi - 在 PowerBI 免费试用帐户上安装 Analysis Services 客户端库
- python - 如何计算将训练数据和测试数据存储在两个不同的 csv 文件中的模型的 F1 分数或准确度分数?
- reactjs - How not to send information until a strong password is selected?