c++ - 诡异的 QTcpSocket 行为
问题描述
在调试接下来的几行代码时,我一直在做噩梦,一定有一些东西隐藏在我所看到的之外。
这是客户端和服务器之间的连接
QByteArray Client::request(QByteArray cmd)
{
//DEBUG << "Command: " << cmd.toStdString().c_str();
QTcpSocket *socket = new QTcpSocket(this);
socket->connectToHost(hostAddress, port, QIODevice::ReadWrite);
if (socket->waitForConnected(TIMEOUT))
{
socket->write(cmd);
DEBUG << "Size of bytes written :" << sizeof (cmd);
}
else DEBUG << "Couldn't connect to socket";
if (socket->waitForBytesWritten(TIMEOUT)) DEBUG << "Command sent";
else DEBUG << "Couldn't write to socket";
if (socket->waitForReadyRead(TIMEOUT))
{
QByteArray data = socket->readAll();
socket->close();
return data;
}
else DEBUG << "No reply from Server";
return QByteArray();
}
对于客户端和服务器来说,基本上就是这样,这里是重要的片段。
class ConnectionHandler : public QTcpServer
{
Q_OBJECT
public:
explicit ConnectionHandler(QObject *parent = 0);
void write(QByteArray);
protected:
void ConnectionHandler::incomingConnection(qintptr descriptor)
{
DEBUG << "ConnectionHandler:" << "Incoming Connection :" << descriptor;
ConnectionThread *thread = new ConnectionThread(this, descriptor);
connect(thread, &QThread::finished, thread, &QThread::deleteLater);
connect(thread, &ConnectionThread::signalIncomingMessage, this, &ConnectionHandler::slotIncomingMessage);
connect(this, &ConnectionHandler::signalOutgoingMessage, thread, &ConnectionThread::slotOutgoingMessage);
thread->start();
}
public slots:
void slotIncomingMessage(QByteArray);
void slotListen(bool checked){
if (checked)
{
if (!this->listen(QHostAddress::LocalHost, PORT_NUMBER)) {
DEBUG << "ConnectionHandler:" << "Could not start the server!";
} else {
DEBUG << "ConnectionHandler:" << "Listening...";
}
} else {
this->close();
DEBUG << "ConnectionHandler:" << "Connection Closed!";
}
}
signals:
void signalOutgoingMessage(QByteArray);
};
class ConnectionThread : public QThread
{
Q_OBJECT
public:
ConnectionThread(QObject* parent = 0, qintptr descriptor = -1){
if (descriptor != -1)
{
socket = new QTcpSocket();
DEBUG << "ConnectionThread: Connecting to socket number" << descriptor;
if (!socket->setSocketDescriptor(descriptor))
{
DEBUG << "ConnectionThread: Connection failed.";
DEBUG << socket->errorString();
}
else
{
DEBUG << "ConnectionThread: Connected Successfully.";
connect(socket, &QAbstractSocket::disconnected, this, &ConnectionThread::slotSocketDisconnected);
}
}
else {
DEBUG << "ConnectionThread: Please provide a descriptor for the connection thread";
}
}
void run() override{
if (socket->state() != QAbstractSocket::ConnectedState)
{
DEBUG << "ConnectionThread: Socket is not connected!";
DEBUG << "ConnectionThread: Closing Thread!";
emit signalThreadError(socket->errorString());
}
else
{
DEBUG << "ConnectionThread: Socket is Connected.";
connect(socket, &QIODevice::readyRead, this, &ConnectionThread::slotThreadReadyRead, Qt::DirectConnection);
exec();
}
}
signals:
void signalThreadError(QString);
void signalIncomingMessage(QByteArray);
public slots:
void slotThreadReadyRead(){
QByteArray msg = socket->readAll();
if (!msg.isEmpty()) {
emit signalIncomingMessage(msg);
}
DEBUG << "ConnectionThread: Data in:" << msg;
}
void slotSocketDisconnected();
void slotOutgoingMessage(QByteArray msg)
{
if (socket != nullptr) {
socket->write(msg);
if (socket->waitForBytesWritten(TIMEOUT)) {
DEBUG << "ConnectionThread: Outgoing Message: " << msg;
} else {
DEBUG << "ConnectionThread: Outgoing Message Timeout";
}
}
}
private:
QTcpSocket *socket = nullptr;
};
基本上会发生什么,它有时会收到来自客户端的传入命令,而大多数时候它不会,不仅如此,它实际上会接收一些命令并忽略一些不同的命令。
这是一个更诡异的行为,注意 中的行//DEBUG << "Command: " << cmd.toStdString().c_str();
,Client::request()
当这行被注释掉时,服务器实际上收到了一些命令,如果没有,服务器是聋的。
这是该行被注释掉时的输出:
Size of bytes written : 8
Command sent
target num = 4 (a reply was received)
Size of bytes written : 8
Command sent
No reply from Server
当提到的行没有被注释掉时,这是另一个输出:
Command: NUMB
Size of bytes written : 8
Command sent
No reply from Server
target num = 0
Command: TRAN
Size of bytes written : 8
Command sent
No reply from Server
更新 解决在客户端写入套接字和线程打开之间发生的竞争对我来说是这样做的,在我的情况下线程使用是不必要的,所以我只是放弃了它。由@Botje 回答
解决方案
问题是由竞争条件引起的:
- (主线程) ConnectionHandler::incomingConnection 创建一个新的 ConnectionThread
- (主线程) ConnectionThread 构造函数创建一个套接字,该套接字也归主线程所有
- (主线程)返回事件循环,轮询套接字上的传入数据
- (ConnectionThread) run 方法将一个槽连接到 readyRead 信号
如果数据在 2 和 4 之间的窗口中到达,readyRead 信号就不会接收到它。有几种可能的解决方案,但最简单的可能是在构造后将套接字移动到 ConnectionThread,或者将其构造延迟到 ConnectionThread::run 方法。
推荐阅读
- spring-boot - Spring JPA 事务 ID
- swift - 移动 SpriteNode 纹理但不移动 PhysicBody
- python - 对 API 的 Python POST 请求出现问题
- php - PSR-1:2.3。副作用:配置文件中的变量
- typescript - 如何从 NPM 模块中导出 ENUM
- swift - 如何在 Swift / Vapor 中引发自定义错误消息?
- java - 从没有修剪()的字符串的开头和结尾删除空格
- javascript - 自动完成错误“超出最大调用堆栈大小”
- loops - 合并相同的单元格,循环遍历 Excel 表格的几列(listobject)
- java - 基于 Spring Boot 角色的身份验证不识别角色