时间戳

首页 > 解决方案 > RVO 是预期的，但没有发生

c++ - RVO 是预期的，但没有发生

问题描述

我有以下连接池的基本实现。在非常高的级别上，它为客户端提供了一种从池中获取打开连接的安全方式，或者如果所有连接当前都在使用中，则打开一个新连接。结构是连接的Connection低级实现。ClientConnectionstruct 是一个包装器，因此Connection客户端只能有限地访问对象，并为使用 RAII 将对象返回到池中Connection提供一种安全的方式。Connection打电话时Pool::getNewConnection()，我预计 NRVO 会发生，但它没有发生，我终生无法弄清楚原因。我希望只调用一次析构函数，因为我创建了ClientConnectioninmain()然后它被销毁了。但是，发生的情况是在Pool::getNewConnection()，然后移动到对象的内存中main()，因此调用了2个析构函数。

g++ -std=c++17 -O0 -g -o main main2.cpp使用和构建g++ -std=c++17 -O3 -g -o main main2.cpp

输出是：

$ ./main 
Opening connection
Pool::getNewConnection() -- Address of newClientConnection: 0x7ffe3d29c290
ClientConnection(ClientConnection&&) -- old: 0x7ffe3d29c290 new: 0x7ffe3d29c320
ClientConnection::~ClientConnection() -- Returning this connection back to pool: 0x7ffe3d29c290
Pool::returnConnection() -- Returned connection: 0x7ffe3d29c290
Writing
ClientConnection::~ClientConnection() -- Returning this connection back to pool: 0x7ffe3d29c320
Pool::returnConnection() -- Returned connection: 0x7ffe3d29c320

#include <iostream>
#include <memory>
#include <vector>

struct Connection {
  bool open(std::string /* ip */, std::uint16_t /* port */) {
    std::cout << "Opening connection\n";
    return true;
  }
  bool close() {
    std::cout << "Closing connection\n";
    return true;
  }
  bool write(const char*) { return true; }
  bool read(const char*) { return true; }
};

struct ClientConnection;

struct Pool {
  ClientConnection getNewConnection();
  void returnConnection(ClientConnection& clientConnection);

private:
  friend class ClientConnection;

  std::vector<std::unique_ptr<Connection>> m_connections;
};

struct ClientConnection {
  ClientConnection()                        = delete;
  ClientConnection(const ClientConnection&) = delete;
  ClientConnection(ClientConnection&& rhs) noexcept : m_pool(rhs.m_pool), m_connection(std::move(rhs.m_connection)) {
    std::cout << "ClientConnection(ClientConnection&&) -- old: " << std::addressof(rhs) << " new: " << this
              << std::endl;
  }

  ClientConnection& operator=(const ClientConnection&) = delete;
  ClientConnection& operator=(ClientConnection&&) = delete;
  ~ClientConnection() noexcept {
    std::cout << "ClientConnection::~ClientConnection() -- Returning this connection back to pool: " << this
              << std::endl;
    m_pool.returnConnection(*this);
  }

  bool write(const char*) {
    std::cout << "Writing\n";
    if (!m_connection->write(nullptr)) {
      m_connectionValid = false;
    }
    return m_connectionValid;
  }

  bool read(const char*) {
    if (!m_connection->read(nullptr)) {
      m_connectionValid = false;
    }
    return m_connectionValid;
  }

private:
  friend class Pool;

  ClientConnection(Pool& pool, std::unique_ptr<Connection> connection)
      : m_pool(pool), m_connection(std::move(connection)) {}

private:
  bool m_connectionValid = true;
  Pool& m_pool;
  std::unique_ptr<Connection> m_connection;
};

ClientConnection Pool::getNewConnection() {
  if (m_connections.empty()) {
    auto conn = std::make_unique<Connection>();
    conn->open("", 0);
    auto newClientConnection = ClientConnection(*this, std::move(conn));
    std::cout << "Pool::getNewConnection() -- Address of newClientConnection: " << std::addressof(newClientConnection)
              << std::endl;
    return newClientConnection;
  } else {
    auto newClientConnection = ClientConnection(*this, std::move(m_connections.back()));
    m_connections.erase(std::prev(m_connections.end(), 1));
    return newClientConnection;
  }
}

void Pool::returnConnection(ClientConnection& clientConnection) {
  if (clientConnection.m_connectionValid) {
    m_connections.push_back(std::move(clientConnection.m_connection));
    std::cout << "Pool::returnConnection() -- Returned connection: " << std::addressof(clientConnection) << std::endl;
  } else {
    clientConnection.m_connection->close();
  }
}

int main() {
  Pool p;
  auto conn = p.getNewConnection();
  conn.write(nullptr);
  return 0;
}

标签： c++c++17nrvo

解决方案

不保证 NRVO。编译器可能会错过使用它的机会。

确保复制省略的替代方法是使用有保证的替代形式。

类似于以下内容：

ClientConnection Pool::getNewConnection()
{
    if (m_connections.empty()) {
        auto conn = std::make_unique<Connection>();
        conn->open("", 0);
        // Skip (problematic) debug display which introduces name for ClientConnection 
        return {*this, std::move(conn)};
    } else {
        struct OnScopeEnd // You might have equivalent util class
        {
            std::vector<std::unique_ptr<Connection>>& m_connections;
            ~OnScopeEnd() { m_connections.pop_back(); }
        } onScopeEnd{m_connections};
        return {*this, std::move(m_connections.back())};
    }
}

推荐阅读